On 4 May 2012 11:58, Eric Anholt <[email protected]> wrote: > On Wed, 2 May 2012 14:30:04 -0700, Paul Berry <[email protected]> > wrote: > > This patch adds a new test, "depthstencil-render-miplevels", which > > verifies that we can render to all miplevels of depth and stencil > > textures. It exposes two bugs in Mesa's current i965 driver: > > Piglit is generally a C project. I'd rather see the test moved to a .c > file and the anonymous namespace dropped. >
Can you elaborate on what the benefit would be of this change? Granted, Piglit is mostly C, but it has some C++ code as well. Changing this source file from C++ to C would mean that in the future, if we wanted to use C++ features in this test, or interface this code with some of Piglit's other C++ code, we would have to switch it back to C++, or do some otherwise unnecessary hack, like placing the C++-using functions in a separate file. Although we're unlikely to need to make use of C++ in this test in the future, it seems better to stay flexible, all other things being equal.
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
