> > I included this as sub test (only for color buffer blits) in a patch posted > on May 7: > [PATCH] Add test to verify glBlitFramebuffer with multisample framebuffer > objects. > In this patch, I am just clearing the multisample buffers to unique colors to > do the testing. > This patch definitely require an update after the recent splitting of > accuracy test. I would > love to see your comments to improve this patch. > > Your patch looks better to me as it includes testing of depth and stencil > buffer blits as well. > Keeping the clear color version of same test has no added advantage. So, I > will exclude this > test case from the list of sub tests in above mentioned patch. > > Reviewed-by: Anuj Phogat <[email protected]>
If you prefer to keep all multisample blitting cases in a single test, I am happy to merge the two patches and send it to the mailing list: 1. [PATCH] Add test to verify glBlitFramebuffer with multisample framebuffer objects. 2. [PATCH 1/2] Add a test of MSAA-to-MSAA blits. OR I will split my patch and post rest of the blitting cases as separate tests. Thanks Anuj _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
