-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 06/06/2012 12:40 PM, Brian Paul wrote:
> This is basically code that was in the old integer-texture test.
> This test just validates GL error detection for glReadPixels, glDrawPixels,
> glTexImage, etc. with regard to signed/unsigned integer formats.
> ---
> tests/all.tests | 1 +
> tests/spec/gl-3.0/api/CMakeLists.gl.txt | 1 +
> tests/spec/gl-3.0/api/integer-errors.c | 182
> +++++++++++++++++++++++++++++++
> 3 files changed, 184 insertions(+), 0 deletions(-)
> create mode 100644 tests/spec/gl-3.0/api/integer-errors.c
[snip]
> + /* Check glTexSubImage for invalid format/type combination */
> + {
> + /* make valid texture image here */
> + glTexImage2D(GL_TEXTURE_2D, 0, GL_RGBA32UI_EXT, 8, 8, 0,
> + GL_RGBA_INTEGER, GL_UNSIGNED_INT, NULL);
> +
> + glTexSubImage2D(GL_TEXTURE_2D, 0,
> + 0, 0, 4, 4,
> + GL_RGBA_INTEGER, GL_FLOAT, NULL);
> + if (!piglit_check_gl_error(GL_INVALID_ENUM))
> + return false;
> + }
For the glTexSubImage case, it looks like the test incorrectly passes if the
first
call to glTexSubImage fails. Placing `if(!piglit_check_gl_error(GL_NO_ERROR))
return false`
after the call should fix it.
Other than that,
Reviewed-by: Chad Versace <chad.vers...@linux.intel.com>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iQIcBAEBAgAGBQJP0Q/GAAoJEAIvNt057x8ibZYP/3PjD3pQ02f0AaNWaknkHzqK
/u3urihrK7vlq9Ql7UNUOUs0ZFVa3HWR9BYnfU30fZwH2D6vDOq1MrTK0IPHN991
4lqbitagnttPT7r4qKZUModrx2N5TanefH5YEVpP4nr58zgGK0EM0EyR0nt/2uJK
zbfH7v2KJeTatEYszjIKmEMCTdZThWaPSsQvzsAkP2lHTIkarsn8oJWLq90CkuLO
Fz9/Lxyr97VpVnQQsinO2jGKOs3uh3ntNal15Fz6KTtS/EY66zFyEaAVNbz4KKK2
4K57B0axyHtTBq8rZAlIlIrULYK7FfbNgR0NxwvShFXcF2MQJMUfH7oxcmedeBOt
XIHLVPP2IMSl0sZYYOdSQ5IZnWG3gQ5BY+fvpVnvb5uhWudR9pW4r9Zm0omANJdz
INmAb15UNKYbUWwWVPYZ9TPq++jgeu5dIhzbSdLbZ8Q7zZxrNXziK7rWJgviGsVs
p35THpZAOSxPdJjf9AFJK8eYs0M5KoR29Q5JknQw5H4Hk3m0NB5+pkgRrHF1eMIJ
w3ncbLSkoxfFg+zxD16aWuLMJwo+SZWQ4qgROu8qdxV72wRBP9jKBQ8blTlJ3ev6
54HVk5ZWUKrAAi7n7ihTnVv+GrEldv96jMC0UZA+YQ1gtWN7WViR8cYUMQ2hxJdn
9DfZ2iyevwPL6Faiw/dk
=iQr6
-----END PGP SIGNATURE-----
_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
