On 10/08/2012 04:57 PM, Matt Turner wrote:
> ---
> tests/all_egl.tests | 1 +
> .../spec/egl_khr_create_context/CMakeLists.gl.txt | 1 +
> .../spec/egl_khr_create_context/invalid-profile.c | 105
> ++++++++++++++++++++
> 3 files changed, 107 insertions(+), 0 deletions(-)
> create mode 100644 tests/egl/spec/egl_khr_create_context/invalid-profile.c
>
> diff --git a/tests/all_egl.tests b/tests/all_egl.tests
> index 370dd88..12d4edc 100644
> --- a/tests/all_egl.tests
> +++ b/tests/all_egl.tests
> @@ -34,3 +34,4 @@ create_context['invalid attribute GL'] =
> plain_test('egl-create-context-invalid-
> create_context['invalid flag GLES'] =
> plain_test('egl-create-context-invalid-flag-gles')
> create_context['invalid flag GL'] =
> plain_test('egl-create-context-invalid-flag-gl')
> create_context['valid forward-compatible flag GL'] =
> plain_test('egl-create-context-valid-flag-forward-compatible-gl')
> +create_context['invalid profile'] =
> plain_test('egl-create-context-invalid-profile')
> diff --git a/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
> b/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
> index 14108f1..240a007 100644
> --- a/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
> +++ b/tests/egl/spec/egl_khr_create_context/CMakeLists.gl.txt
> @@ -24,6 +24,7 @@ piglit_add_executable
> (egl-create-context-invalid-attribute-gles invalid-attribu
> piglit_add_executable (egl-create-context-invalid-attribute-gl
> invalid-attribute-gl.c common.c)
> piglit_add_executable (egl-create-context-invalid-flag-gles
> invalid-flag-gles.c common.c)
> piglit_add_executable (egl-create-context-invalid-flag-gl invalid-flag-gl.c
> common.c)
> +piglit_add_executable (egl-create-context-invalid-profile invalid-profile.c
> common.c)
> piglit_add_executable (egl-create-context-valid-flag-forward-compatible-gl
> valid-flag-forward-compatible-gl.c common.c)
>
> # vim: ft=cmake:
> diff --git a/tests/egl/spec/egl_khr_create_context/invalid-profile.c
> b/tests/egl/spec/egl_khr_create_context/invalid-profile.c
> new file mode 100644
> index 0000000..d7aece8
> --- /dev/null
> +++ b/tests/egl/spec/egl_khr_create_context/invalid-profile.c
> @@ -0,0 +1,105 @@
> +/* Copyright © 2012 Intel Corporation
> + *
> + * Permission is hereby granted, free of charge, to any person obtaining a
> + * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and to permit persons to whom the
> + * Software is furnished to do so, subject to the following conditions:
> + *
> + * The above copyright notice and this permission notice (including the next
> + * paragraph) shall be included in all copies or substantial portions of the
> + * Software.
> + *
> + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
> + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
> + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
> DEALINGS
> + * IN THE SOFTWARE.
> + */
I'd prefer to see a file-level comment here that gives a brief summary of the
test and explains how the test checks for correct handling of invalid profiles.
Without any documentation, someone has to read to the entire test to figure out
what it's doing.
Otherwise, the test looks good.
> +#include "piglit-util-gl-common.h"
> +#include "piglit-util-egl.h"
> +#include "common.h"
_______________________________________________
Piglit mailing list
Piglit@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/piglit
