On Fri, Oct 19, 2012 at 9:54 AM, Chad Versace <[email protected]> wrote: > This series looks good to me. > Reviewed-by: Chad Versace <[email protected]> > > I wanted to test the series, but the python patches wouldn't apply :(
I rebased the changes to master here: git://people.freedesktop.org/~jljusten/piglit gbm Let me know if you are ready for me to push the changes to master. > I still want to discuss with you how to get the gbm tests running under X and > Wayland when we're in the office at the same time. If you have waffle installed into your system prefix and you want to test the system mesa/GL, then something like: sudo ./piglit-run.py -p gbm ... Should work. Now, if you use a separate prefix (like me), then you'll need to take extra steps to make sure the root user is setup for loading waffle & mesa from the alt prefix. -Jordan > On 10/09/2012 04:42 PM, Jordan Justen wrote: >> Dependencies: >> * Waffle 1.1 >> * Chad Versace's "Support tests for GL core contexts" series >> >> Some results I've seen: >> GLX: 9092/9294 >> GBM (waffle master): 8245/8417 >> GBM (w/unpushed changes): 8673/8820 >> >> Notes: >> * When X is running, waffle-gbm currently must be run as root >> * When outside of X, a normal user can be used, but you should >> not run tests concurrently: piglit-run.py -c 0 >> >> Jordan Justen (8): >> piglit-run.py: add -p|--platform switch to select the piglit platform >> exectest.py: move test launch code out to get_command_result routine >> exectest.py: add path to mark a test as always skipped >> exectest.py: set python PIGLIT_PLATFORM from environment variable >> gbm: when using gbm, skip running glean tests >> gbm: when using gbm, skip running glx tests >> waffle: require waffle >= 1.1 >> piglit framework: add gbm support >> >> CMakeLists.txt | 5 +- >> framework/core.py | 1 + >> framework/exectest.py | 83 >> ++++++++++++++------ >> piglit-run.py | 10 ++- >> tests/util/CMakeLists.txt | 1 + >> .../piglit-framework-gl/piglit_gbm_framework.c | 78 ++++++++++++++++++ >> .../piglit-framework-gl/piglit_gbm_framework.h | 29 +++++++ >> .../piglit-framework-gl/piglit_wfl_framework.c | 10 +++ >> .../piglit-framework-gl/piglit_winsys_framework.c | 6 ++ >> 9 files changed, 195 insertions(+), 28 deletions(-) >> create mode 100644 tests/util/piglit-framework-gl/piglit_gbm_framework.c >> create mode 100644 tests/util/piglit-framework-gl/piglit_gbm_framework.h >> > > _______________________________________________ > Piglit mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/piglit _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
