On 11/28/2012 12:29 PM, Eric Anholt wrote: > Chad Versace <[email protected]> writes: > >> This field allows a test to declare support for any GLES version. It >> replaces fields 'supports_gl_es1' and 'supports_gl_es2'. >> >> The valid range for the field is currently [1.0, 3.0), though it will soon >> get bumped to [1.0,4.0). > > These continuous ranges are weird, given that the only two values really > supported (as far as I can tell) are exactly 1.0 or exactly 2.0.
The requested ES version gets passed directly to waffle. So, if a test stupidly sets `supports_gl_es_version = 25`, then 2.5 gets passed to waffle_context_create and then to eglCreateContext, and should fail there. In other words, there does exist a safeguard against stupid values. >> One advantage of this field is that it introduces symmetry among the >> 'supports_gl' fields. Before this patch, two fields were integers >> (supports_gl_core_version, supports_gl_compat_version) and two were >> booleans (supports_gl_es1, supports_gl_es2). Now they're all integers and >> behave similarly. > > I'm in favor of that, for sure! Good! This is the one point in the series that I feared a NAK. I was really hoping no one wanted a piglit_gl_test_config::supports_gl_es3. >> This patch also updates, with the subistition below, the tests that used > ^ spelling Fixed. _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
