On Mon, Dec 17, 2012 at 12:33 PM, Chad Versace <[email protected]> wrote: > On 12/14/2012 12:01 PM, Tom Gall wrote: >> This is a set of trivial changes. In the appropriate set of >> tests/glslparsertests/shaders/*.frag which are targeted for >> glsl_version 1.10 or 1.20, add glsles_version: 1.00 which >> identifies the test as appropriate for glsl es 1.0 which lines up >> with gles2. >> >> Signed-off-by: Tom Gall <[email protected]> >> --- >> tests/glslparsertest/shaders/CGDataTypes.frag | 1 + > >> diff --git a/tests/glslparsertest/shaders/CGDataTypes.frag >> b/tests/glslparsertest/shaders/CGDataTypes.frag >> index bda4a81..d144b07 100644 >> --- a/tests/glslparsertest/shaders/CGDataTypes.frag >> +++ b/tests/glslparsertest/shaders/CGDataTypes.frag >> @@ -1,6 +1,7 @@ >> // [config] >> // expect_result: fail >> // glsl_version: 1.10 >> +// glsles_version: 1.00 > > Maybe I haven't been following the gles2 glslparsertest activity as closely as > I should have, but: after this series, does the gles2 glslparsertest > successfully > execute these tests? That is, do the tests pass?
Yes, I've run these as both GLES2 and GL successfully. There's a few I'm working through now that look to correctly fail on GLES2 because of GLSL ES 1.00 limitations. I'm crawling through those one by one. It's a bit slow work as I'm validating each with the GLSL ES 1.00 spec. > By the way, all the commit messages in this series are indented weirdly. The > first > line is left-justified, and all following lines are indented 2 spaces. Hmmm. Will have a look and certainly fix! Thanks! -- Regards, Tom "Where's the kaboom!? There was supposed to be an earth-shattering kaboom!" Marvin Martian Graphics Working Group | Linaro.org │ Open source software for ARM SoCs w) tom.gall att linaro.org h) tom_gall att mac.com _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
