Matt Turner <[email protected]> writes: > On Thu, Dec 20, 2012 at 10:54 AM, Tom Gall <[email protected]> wrote: >> A few variations are commented out due to results that are >> incorrect and need to be followed up with Mesa, such as modifying >> the buffer even tho the format is invalid. There are cases where >> the returned data is incorrectly formated. These can best be >> addressed in time and I thought it best to include the variations >> but in their commented out form. > > I think Eric already told you that it's okay to commit failing tests.
Not just okay, it's expected. Other note: I don't think the name "unit" belongs in this. Nothing in piglit is a unit test according to what I've understood or how unit tests are described on wikipedia. There's still a bunch of style mess in this file, too.
pgp5efVU60AsW.pgp
Description: PGP signature
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
