Marek Olšák <[email protected]> writes: Could you give it a more informative name than "primgen"? Like "primgen-rasterizer-discard" or something? Other than that, 2 minor suggestions you can take or leave.
> +enum piglit_result piglit_display(void)
> +{
> + glClear(GL_COLOR_BUFFER_BIT);
> + glBeginQuery(GL_PRIMITIVES_GENERATED, q);
> +
> + glLoadIdentity();
Superfluous, right? The matrix never changes?
> + glUseProgram(prog);
> + glVertexPointer(2, GL_FLOAT, 0, verts);
> + glDrawElements(GL_TRIANGLES, 6, GL_UNSIGNED_INT, indices);
I don't think piglit_draw_rect() would ever produce other than 2 prims,
which could simplify this test.
pgpQeytTakJ7R.pgp
Description: PGP signature
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
