On 04/19/2013 09:54 PM, Dylan Baker wrote:
I have some concerns with this patch: 1) It has two imports that are not being used: cgi, os (not os.path)
I'll fix that.
2) getopt: I've been trying to get rid of getopt and replace it with argparse (I have a patch set ready to go to replace the rest of optparse and getopt with argparse)
I just copied the other scripts. Feel free to fix it.
3) using the name piglit-summary.py: If the project ever wanted to have a unified summary program that could output different summary formats (which seems like a good idea as the project gets more and more summary output types) the logical name would be piglit-summary.py. This creates friction since that kind of feature would be changing the functionality of an existing tool in the project.
We can easily rename the script when that day comes. -Brian _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
