On 19 April 2013 12:05, Jordan Justen <[email protected]> wrote:
> Certain uniform or varying qualifiers can only be used with > uniform or varying interfaces. > > Signed-off-by: Jordan Justen <[email protected]> > IMHO patches 4-6 are overkill just to allow us to combine these 9 test cases into a single file. I'd prefer to see them split out into 9 separate glslparsertest files. There's plenty of precedent for that elsewhere in Piglit. There's also all the usual advantages of keeping test cases separate (e.g. if a bug causes one of the tests to fail, we will still notice a regression that causes another test to fail). I'm also uncomfortable with shader_runner growing features to allow it to test shaders that are expected not to compile. Shader_runner is already pretty unweildy as it is, and using it to verify that shaders fail to compile seems like it's wandering too far from its usual purpose. > --- > ...ce-blocks-invalid-member-qualifiers.shader_test | 52 > ++++++++++++++++++++ > 1 file changed, 52 insertions(+) > create mode 100644 > tests/spec/glsl-1.50/compiler/interface-blocks-invalid-member-qualifiers.shader_test > > diff --git > a/tests/spec/glsl-1.50/compiler/interface-blocks-invalid-member-qualifiers.shader_test > b/tests/spec/glsl-1.50/compiler/interface-blocks-invalid-member-qualifiers.shader_test > new file mode 100644 > index 0000000..62116ca > --- /dev/null > +++ > b/tests/spec/glsl-1.50/compiler/interface-blocks-invalid-member-qualifiers.shader_test > @@ -0,0 +1,52 @@ > +[require] > +GLSL >= 1.50 > + > +[vertex shader] > +uniform block { > + smooth float a; > +}; > + > +[vertex shader] > +uniform block { > + flat float a; > +}; > + > +[vertex shader] > +uniform block { > + noperspective float a; > +}; > + > +[vertex shader] > +uniform block { > + centroid out float a; > +}; > + > +# Vertex shader out block tests > +[vertex shader] > +out block { > + layout(shared) mat4 a; > +}; > + > +[vertex shader] > +out block { > + layout(packed) mat4 a; > +}; > + > +[vertex shader] > +out block { > + layout(std140) mat4 a; > +}; > + > +[vertex shader] > +out block { > + layout(row_major) mat4 a; > +}; > + > +[vertex shader] > +out block { > + layout(column_major) mat4 a; > +}; > + > +[test] > +compile error > + > -- > 1.7.10.4 > > _______________________________________________ > Piglit mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/piglit >
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
