On Tue, May 7, 2013 at 4:13 PM, Chad Versace <[email protected]> wrote: > >> +void >> +piglit_destroy_dma_buf(struct piglit_dma_buf *buf); > > > Is it safe to pass NULL to this function, like free()? Please document that. > > With that documentation, this patch is > Reviewed-by: Chad Versace <[email protected]> >
I also agree that this should be documented. For ease of use, I would recommend that this function be documented that passing NULL results in no action ( Similar to how free acts ). However, as it is Implemented right now, I do not believe the function drm_intel_bo_unreference used in actual implementation may not be safe to having NULL pointers passed. _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
