It's been a 9 days since this patch set was reviewed by Dylan. That said, This patch has no major problems that should keep this from being installed. In fact it is only a benefit since the piglit folder could be read only and allowing relative path handling, this will keep the python scripts from failing when used. Read Only piglit paths are found in larger scale testing systems where the desired application is compile once, and then copy the binaries across multiple computers.
An example of a reasonably large scale testing would be the Ubuntu Xorg edgers packaging for piglit.[1] This package is a prime example of a system that could be used internally at some companies wishing to develop patches fixes for drivers because it allows the company to be able to rapidly develop and deploy a single image without worry. [1] Xorg edgers package for Ubuntu. https://launchpad.net/~xorg-edgers/+archive/piglit NOTE: I know that the xorg edgers package applies three small patches similar to this patch set to allow the python scripts to work as intended. On Mon, Apr 29, 2013 at 10:10 PM, Dylan Baker <[email protected]> wrote: > Looks good to me. > > All patches: > Reviewed-by: Dylan Baker <[email protected]> > > > On Mon, Apr 29, 2013 at 8:50 AM, Kenney Phillis <[email protected]> > wrote: >> >> A small set of fixes that are essential for distributed testing. This is >> important for when you are Building piglit once and then distributing the >> build over a network to multiple computers for serious regression testing. >> >> Kenney Phillis (2): >> piglit-run.py: Fix Path resolution >> framework/core.py: fix path resolution when loading test results. >> >> framework/core.py | 3 ++- >> piglit-run.py | 4 +--- >> 2 files changed, 3 insertions(+), 4 deletions(-) >> >> -- >> 1.7.9.5 >> >> _______________________________________________ >> Piglit mailing list >> [email protected] >> http://lists.freedesktop.org/mailman/listinfo/piglit > > _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
