No, it doesn't need a core profile. i have squashed your patch with mine and pushed the commit.
As you have probably noticed, the test fails with Mesa. I think it's a deficiency of our GLSL linker, which assigns somewhat unfriendly IDs to samplers. (if a vertex shader uses 16 samplers, the first fragment shader sampler will be declared as SAMP[16] in TGSI, which seems wrong). Marek On Thu, May 9, 2013 at 4:21 PM, Brian Paul <[email protected]> wrote: > On 05/08/2013 07:27 PM, Marek Olšák wrote: >> >> On Thu, May 9, 2013 at 1:16 AM, Brian Paul<[email protected]> wrote: > > >>> >>> BTW, I tried to test this with NVIDIA's driver but it appears that piglit >>> can't create a GL 3.1 context: >>> >>> $ bin/gl-3.1-max-samplers -auto >>> piglit: info: Failed to create GL 3.1 core context >>> piglit: info: Failed to create any GL context >>> PIGLIT: {'result': 'skip' } >> >> >> The issue with NVIDIA's driver is that it advertises >> ARB_compatibility, so it's not a 3.1 core profile. Piglit sees that >> and assumes the context creation failed and skips the test. > > > It also doesn't run if I try to request a GL 3.1 compatibility context. > > Does this test really need GL 3.1? I changed the test to use > config.supports_gl_compat_version = 20 (AFAICT only GL 2.0 features are > used). Plus, I had to increase the window size to 300x300 because 32 > vertex/fragment image units are reported on my system. Now the test passes > with my NVIDIA driver. > > A patch with my changes is attached. > > -Brian _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
