On 05/31/2013 12:50 PM, Paul Berry wrote:
When running piglit in manual mode (no "-auto" command-line option is
given), there's no point in calling piglit_display() before the window
is exposed. This just leads to confusion because it will be called
again once the window appears, leading to duplicate test output in the
console window.
When running piglit in "-auto" mode, if the test accesses the front
buffer, then we need to wait until the window is exposed before
calling piglit_display(), since a front buffer is not guaranteed to be
available before then (in practice, this only happens with
non-compositing window managers). However, if the test doesn't access
the front buffer, then it is still safe to call piglit_display()
before the expose event; doing so avoids wasting time.
Note: there are two known bugs that cause sporadic failures in certain
piglit tests with Mesa/Intel hardware (and possibly other Mesa
drivers). See bugs #1 and #2 in
http://lists.freedesktop.org/archives/mesa-dev/2013-May/039985.html.
This change seems to exacerbate those sporadic failures. As far
as I'm aware, the tests that are affected are:
- spec/!OpenGL 1.1/drawbuffer-modes
- spec/EXT_framebuffer_blit/fbo-sys-blit
- spec/EXT_framebuffer_blit/fbo-sys-sub-blit
I have patches on the list to fix bug #1 from that email (see
http://lists.freedesktop.org/archives/mesa-dev/2013-May/040010.html),
and Eric Anholt is working on bug #2. I believe that once those fixes
land, the above tests should pass consistently.
Based on work by Chad Versace.
Cc: Chad Versace <[email protected]>
Cc: Eric Anholt <[email protected]>
---
tests/util/piglit-framework-gl/piglit_winsys_framework.c | 15 ++++++---------
tests/util/piglit-framework-gl/piglit_x11_framework.c | 5 ++++-
2 files changed, 10 insertions(+), 10 deletions(-)
Looks good to me. The patch only changes behavior when
requires_displayed_window.
Reviewed-by: Chad Versace <[email protected]>
_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit
