On 05/28/2013 02:51 AM, Topi Pohjolainen wrote:
v2: - compile only on platforms that have drm (Eric) - use standard drm definitions for fourcc instead of duplicated local (Daniel, Eric) - use helper variables for width, height and cpp instead of repeating the magic numbers over and over again (Eric) - use the stride and offset provided by the framework instead of hardcoded assumed values (Eric) - rewritten excess attribute test vector using only one set of attributes with a re-writable slot for one excess attribute (Eric) - check that EGL stack does not take the ownersip of the buffer and revise the explanation for it (Eric) - check also for EGL_DMA_BUF_PLANE2_* as excess attributes (Eric) - removed irrelevant quotes of the spec (Eric) - changed the error expected for non-NULL context from 'EGL_BAD_CONTEXT' to 'EGL_BAD_PARAMETER' (Eric)v3: - use properly linked egl-extension calls (Eric) - make a distinction between invalid and unsupported formats. The former is signified by 'EGL_BAD_ATTRIBUTE' while the latter generates 'EGL_BAD_MATCH'. There is test only for the former as the latter is driver dependent. Signed-off-by: Topi Pohjolainen <[email protected]> --- .../ext_image_dma_buf_import/CMakeLists.gles1.txt | 1 + .../ext_image_dma_buf_import/invalid_attributes.c | 265 +++++++++++++++++++++ 2 files changed, 266 insertions(+) create mode 100644 tests/spec/ext_image_dma_buf_import/invalid_attributes.c
+#include "piglit-util-egl.h" +#define EGL_EGLEXT_PROTOTYPES 1 +#include <EGL/eglext.h>
Prototypes again.
+ * * If <target> is EGL_LINUX_DMA_BUF_EXT, and the EGL_LINUX_DRM_FOURCC_EXT + * attribute is set to a format not supported by the EGL, EGL_BAD_MATCH + * is generated.
The above item needs to be removed, because this test doesn't check for EGL_BAD_MATCH anywhere, as noted in your v3 comments. Otherwise, the test looks good. _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
