On 6 August 2013 14:08, Paul Berry <[email protected]> wrote:

> On 5 August 2013 15:32, Anuj Phogat <[email protected]> wrote:
>
>> This test verifies the accuracy of scaled blitting from a single sample
>> buffer with GL_LINEAR filtering. It compares the output from following
>> rendering scenarios:
>> 1. Scaled blit using a single sample framebuffer with texture /
>>    renderbuffer attachment.
>> 2. Scaled blit using a glsl shader program.
>> Signed-off-by: Anuj Phogat <[email protected]>
>> ---
>>  tests/all.tests                                    |   1 +
>>  .../ext_framebuffer_multisample/CMakeLists.gl.txt  |   1 +
>>  .../blit-scaled-linear.cpp                         | 297
>> +++++++++++++++++++++
>>  3 files changed, 299 insertions(+)
>>  create mode 100644
>> tests/spec/ext_framebuffer_multisample/blit-scaled-linear.cpp
>>
>
> I see that you've placed this test in ext_framebuffer_multisample because
> it re-uses the test pattern defined in
> ext_framebuffer_multisample/common.cpp.  I'm not comfortable with that--if
> we start mixing and matching our directory organization like this, it's
> going to start getting hard to find the files we're looking for.  How about
> if we do a pre-patch that moves the test pattern to a global location (i.e.
> somewhere in tests/util)?  Then this test can go in
> arb_framebuffer_multisample where it belongs.
>

Sorry, I meant to say "Then this test can go in arb_framebuffer_object
where it belongs".
_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to