On 9 August 2013 14:56, Anuj Phogat <[email protected]> wrote: > A lot of classes and functions in ext_framebuffer_multisample/common.cpp > can be utilized to develop new piglit test cases. This patch moves the > Fbo and test_pattern classes to a global location tests/util. > Functions from these classes will be utilized in my later patches for > tests in spec/arb_framebuffer_object. > > Signed-off-by: Anuj Phogat <[email protected]> >
Thanks for taking the time to do this, Anuj. I have just one small concern: when we were talking about this in person last week, I seem to remember us deciding that the classes should either be renamed to give them a prefix, or put in a new namespace. Does that seem reasonable to you? I'm worried about some of the shorter class names (like "Fbo") conflicting with variables and classes we try to make in the future. I have a minor preference for using a namespace rather than a prefix, mostly because I think it will be easier, but I could go either way. With that addressed, this patch is: Reviewed-by: Paul Berry <[email protected]> I didn't get a chance to read through patches 2 and 3 in detail, but I verified that they pass on my NVIDIA system, and I confirmed visually that they appear to be doing the right thing, so consider them: Acked-by: Paul Berry <[email protected]>
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
