From: Ian Romanick <[email protected]>

NVIDIA's driver doesn't expose these formats, and nothing in the
ARB_texture_compression_bptc extension spec or OpenGL 4.2 spec seem to
require they be advertised.

With this patch, NVIDIA is closer to passing this test.  However, they
also advertise the GL_OES_compressed_paletted_texture formats without
advertising the extension.

Signed-off-by: Ian Romanick <[email protected]>
Cc: Anuj Phogat <[email protected]>
---
 tests/spec/arb_texture_compression/invalid-formats.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/tests/spec/arb_texture_compression/invalid-formats.c 
b/tests/spec/arb_texture_compression/invalid-formats.c
index 52474a2..310ed75 100644
--- a/tests/spec/arb_texture_compression/invalid-formats.c
+++ b/tests/spec/arb_texture_compression/invalid-formats.c
@@ -81,6 +81,12 @@ struct format_list {
 
 /**
  * Formats belonging to GL_ARB_texture_comrpession_bptc
+ *
+ * The extension spec says nothing about whether or not these must be
+ * advertised via GL_COMPRESSED_TEXTURE_FORMATS.  The OpenGL 4.2 spec also
+ * requires these formats, but it says that GL_NUM_COMPRESSED_TEXTURE_FORMATS
+ * must be at least 0.  NVIDIA's driver does not expose them, so we'll
+ * classify them as optional.
  */
 static const struct format_list bptc_formats = {
        {
@@ -438,7 +444,7 @@ piglit_init(int argc, char **argv)
                                           num_compressed_formats,
                                           check_errors,
                                           
piglit_is_extension_supported("GL_ARB_texture_compression_bptc"),
-                                          false)
+                                          true)
                                && pass;
                } else if (strcmp(argv[i], "s3tc") == 0) {
                        pass = try_formats(&s3tc_formats,
-- 
1.8.1.4

_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to