On Tuesday 17 September 2013 10:54:01 Eric Anholt wrote:
> Otherwise you'd approximately never terminate a run with khronos's
> testsuite included in the run.  If you were lucky.
> ---
>  framework/core.py | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/framework/core.py b/framework/core.py
> index 14d0119..1e3012b 100644
> --- a/framework/core.py
> +++ b/framework/core.py
> @@ -209,6 +209,15 @@ if 'PIGLIT_SOURCE_DIR' not in os.environ:
>      os.environ['PIGLIT_SOURCE_DIR'] = p.abspath(p.join(p.dirname(__file__),
> '..'))
> 
> +# In debug builds, Mesa will by default log GL API errors to stderr.
> +# This is useful for application developers or driver developers
> +# trying to debug applications that should execute correctly.  But for
> +# piglit we expect to generate errors regularly as part of testing,
> +# and for exhaustive error-generation tests (particularly some in
> +# khronos's conformance suite), it can end up ooming your system
> +# trying to parse the strings.
> +if 'MESA_DEBUG' not in os.environ:
> +    os.environ['MESA_DEBUG'] = 'silent'
> 
>  class TestResult(dict):
>      pass

This looks fine.
Reviewed-by: Dylan Baker <[email protected]>

Attachment: signature.asc
Description: This is a digitally signed message part.

_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to