On Wednesday 18 September 2013 15:54:45 Eric Anholt wrote: > Dylan Baker <[email protected]> writes: > > This adds code in framework/summary.py and framework/core.py to make use > > of the status classes in status.py. This makes comparisons between > > statuses much simpler and cleaner > > > > Signed-off-by: Dylan Baker <[email protected]> > > --- > > > > if 'fixes' in lists: > > # Find both fixes and regressions, and append them to > > the > > # proper lists > > > > for i in xrange(len(status) - 1): > > - if status[i] < status[i + 1] and status[i] != 0: > > > > + if status[i] == Pass() and status[i + 1] != Pass(): > > self.tests['regressions'].append(test) > > This fails to report a regression for warn -> fail or fail -> crash. > But be sure that you don't report a regression for fail -> skip. > > This is tricky and really important to get right. > > Also make sure to have some changes involving not-run tests when you > make sure that you get the same html before and after.
noted. I'll fix this and send a v2
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
