On 09/19/2013 06:13 PM, Chad Versace wrote: > On 09/19/2013 01:58 PM, Ian Romanick wrote: >> From: Ian Romanick <[email protected]> >> >> The exact same spec language appears in the 3.1 spec. Currently no Mesa >> driver supports OpenGL 3.2, but there are drivers that support 3.1. >> This allows the test to run now on those drivers. >> >> NOTE: This test currently fails in Mesa. >> >> Signed-off-by: Ian Romanick <[email protected]> >> Cc: Nicholas Mack <[email protected]> >> Cc: Paul Berry <[email protected]> >> --- >> tests/all.tests | 2 +- >> tests/spec/gl-3.1/CMakeLists.gl.txt | 1 + >> tests/spec/gl-3.1/draw-buffers-errors.c | 110 >> ++++++++++++++++++++++++++++++++ >> tests/spec/gl-3.2/CMakeLists.gl.txt | 1 - >> tests/spec/gl-3.2/draw-buffers-errors.c | 110 >> -------------------------------- >> 5 files changed, 112 insertions(+), 112 deletions(-) >> create mode 100644 tests/spec/gl-3.1/draw-buffers-errors.c >> delete mode 100644 tests/spec/gl-3.2/draw-buffers-errors.c >> > > >> +static const GLenum invalids[]={ >> + GL_FRONT, >> + GL_BACK, >> + GL_LEFT, >> + GL_RIGHT, >> + GL_FRONT_AND_BACK >> +}; > > While we're fixing formatting, the above assignment needs ``s/[]={/[] = > {/``.
Dang it! I got the other one. :) > With or without that nit, > Reviewed-by: Chad Versace <[email protected]> > _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
