On Tuesday, October 01, 2013 10:42:39 PM Ken Phillis Jr wrote: > Since i got a few emails over this particular change... I will go ahead and > explain the primary reason for this change. It's a minor change when you > consider that most current linux distributions have included some version > of cmake 2.8 for more than 2 years. Also, The last release for cmake 2.6 > was in 2009, and there was less than a year spent on the CMake 2.6 series. > This means that this is only a slight change to require slightly newer > tools seeing as how cmake 2.8 was released within 6 months of Cmake 2.6.8 ( > see [1] for information ). > > Anyways, for developers working on Windows, Freebsd, and/or Mac OS X, there > is a high chance these developers will install Cmake 2.8 seeing as how this > works on all recent computers. > > [1] Cmake News on kitware's website: > June 11, 2004 - Cmake 2.4 released > http://www.kitware.com/news/home/browse/168?siteid=9 > April 1, 2008 - Cmake 2.4.8 released > http://www.kitware.com/news/home/browse/179?siteid=9 > July 10, 2008 - Cmake 2.6 is released > http://www.kitware.com/news/home/browse/141?siteid=9 > May 5, 2009 - Cmake 2.6.4 is released > http://www.kitware.com/news/home/browse/229?siteid=9 > November 4, 2009 - Cmake 2.8 is released > http://www.kitware.com/news/home/browse/252?siteid=9 > May 22, 2013 - Cmake 2.8.11 is released > http://www.kitware.com/news/home/browse/464?siteid=9 > > On Mon, Sep 30, 2013 at 10:11 PM, Kenney Phillis <[email protected]>wrote: > > Increase the Minimum version of CMake that is required from > > version 2.6 to version 2.8. This is because the minimum requirement > > to compile waffle is version 2.8 > > --- > > > > CMakeLists.txt | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/CMakeLists.txt b/CMakeLists.txt > > index f064b35..0da074a 100644 > > --- a/CMakeLists.txt > > +++ b/CMakeLists.txt > > @@ -1,4 +1,4 @@ > > -cmake_minimum_required(VERSION 2.6) > > +cmake_minimum_required(VERSION 2.8) > > > > list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/Modules") > > > > -- > > 1.7.9.5
That's all fine, however, system dependencies should always be the lowest usable version. if 2.4 would work then we should request 2.4. The availability of a new version is not justification for a version bump.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
