On 10/14/2013 02:05 PM, Paul Berry wrote: > On 14 October 2013 12:44, Ian Romanick <[email protected] > <mailto:[email protected]>> wrote: > > On 10/12/2013 10:11 AM, Paul Berry wrote: > > Previously, built-in-constants looked at required_glsl_version to > > determine what to include in the "#version" directive, but it looked > > at glsl_version (the maximum version supported by the implementation) > > to decide whether to test geometry shaders. As a result, it when > > testing a built-in constant whose required_glsl_version was less than > > 150, it would try to create a geometry shader using a "#version" > > directive less than 150, leading to GL errors. > > > > This patch prevents the problem by only testing geometry shaders when > > required_glsl_version >= 150. > > It's actually even more broken than that. :( Sorry about that. > > If required_glsl_version or glsl_version is 300 (for OpenGL ES 3.0), it > will also try to create a geometry shader. > > How about > > if (required_glsl_version >= 150 && required_glsl_version != 300) > > instead? > > > Oops, good call. With that fixed, do I have your r-b?
Yes, definitely. _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
