On Wed, 2013-10-30 at 11:48 -0700, Ian Romanick wrote:

> Does the test need a non-default size?  The rest of the test code
> appears to adapt to any window size.

Fixed; I just copied the initial code from fbo-sys-sub-blit, and that's
what it did :)

> > +#if SWAP_BUFFERS_BEFORE_BLIT
> 
> Ideally, the test binary should be able to do both these things based on
> a commandline parameter.

Done; added a "no-swap" parameter.

(Tests seem to use dashless parameters; is that ok?  I.e. instead of
"--no-swap".)

>     glColor4fv(red);

Oops, of course.

Since I'm rather a GL newbie, there is no glClearColor4fv(), is there?

> The correct idiom is:
> 
>         pass = ... && pass;

Fixed.

The updated patch is in the next post.

  Federico

_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to