Patches 1 through 7, and 10 are: Reviewed-by: Ian Romanick <[email protected]>
I sent comments on 8 that also apply to 9. I sent minor comments on 11. On 11/14/2013 04:20 AM, Topi Pohjolainen wrote: > Here is a combined series including revision of my api-error set > and some positive cases exercising the limits of the feedback > mechanism in the driver - use of maximum streams, buffers and > geometry shader invocations. > > All are tested on either NVIDIA binary driver or Ivy Bridge. The > former supports all the tests and fails only on one of the api > error corner cases. Ivy Bridge in turn passes all that it > supports but skips quite a few that require also arb_gpu_shader5. > > I got quite a bit of feedback from Ian to the api error tests > which I hope I have addressed all. > > Topi Pohjolainen (11): > arb_transform_feedback3: add test for buffer binding with invalid > index > arb_transform_feedback3: add test for querying with invalid index > arb_transform_feedback3: add test for ending non-active query > arb_transform_feedback3: add test trying to draw an invalid stream > arb_transform_feedback3: add test trying to set invalid varyings > arb_transform_feedback3: add test trying to set invalid separate mode > util: buffer object probe > arb_transform_feedback3: add test for interleaved in max buffers > arb_transform_feedback3: add test for recording max streams > arb_transform_feedback3: add test for interleaved in two buffers > arb_transform_feedback3: add test for re-drawing multiple streams > > tests/all.tests | 15 + > tests/spec/CMakeLists.txt | 1 + > .../spec/arb_transform_feedback3/CMakeLists.gl.txt | 22 ++ > tests/spec/arb_transform_feedback3/CMakeLists.txt | 1 + > .../bind_buffer_invalid_index.c | 124 +++++++ > .../draw_using_invalid_stream_index.c | 104 ++++++ > .../end_query_with_name_zero.c | 64 ++++ > .../ext_interleaved_draw_streams.c | 399 > +++++++++++++++++++++ > .../ext_interleaved_max_buffers_and_varyings.c | 306 ++++++++++++++++ > .../ext_interleaved_max_streams.c | 249 +++++++++++++ > .../ext_interleaved_two_bufs.c | 311 ++++++++++++++++ > .../query_with_invalid_index.c | 109 ++++++ > .../arb_transform_feedback3/set_invalid_varyings.c | 182 ++++++++++ > .../set_varyings_with_invalid_args.c | 118 ++++++ > tests/spec/arb_transform_feedback3/xfb3_common.c | 147 ++++++++ > tests/spec/arb_transform_feedback3/xfb3_common.h | 64 ++++ > tests/spec/ext_transform_feedback/separate.c | 35 +- > tests/util/piglit-util-gl-common.h | 4 + > tests/util/piglit-util-gl.c | 24 ++ > 19 files changed, 2253 insertions(+), 26 deletions(-) > create mode 100644 tests/spec/arb_transform_feedback3/CMakeLists.gl.txt > create mode 100644 tests/spec/arb_transform_feedback3/CMakeLists.txt > create mode 100644 > tests/spec/arb_transform_feedback3/bind_buffer_invalid_index.c > create mode 100644 > tests/spec/arb_transform_feedback3/draw_using_invalid_stream_index.c > create mode 100644 > tests/spec/arb_transform_feedback3/end_query_with_name_zero.c > create mode 100644 > tests/spec/arb_transform_feedback3/ext_interleaved_draw_streams.c > create mode 100644 > tests/spec/arb_transform_feedback3/ext_interleaved_max_buffers_and_varyings.c > create mode 100644 > tests/spec/arb_transform_feedback3/ext_interleaved_max_streams.c > create mode 100644 > tests/spec/arb_transform_feedback3/ext_interleaved_two_bufs.c > create mode 100644 > tests/spec/arb_transform_feedback3/query_with_invalid_index.c > create mode 100644 tests/spec/arb_transform_feedback3/set_invalid_varyings.c > create mode 100644 > tests/spec/arb_transform_feedback3/set_varyings_with_invalid_args.c > create mode 100644 tests/spec/arb_transform_feedback3/xfb3_common.c > create mode 100644 tests/spec/arb_transform_feedback3/xfb3_common.h _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
