Dylan, All my piglit jobs are timing out after this series. They appear to be taking forever on
[Mon Jan 13 16:12:54 2014] :: running :: glean/blendFunc I suspect that with the recent changes, the glean is no longer receiving the --quick option, which is essential. Probably because with the change below, GleanTest.globalParams ends up being modified *after* the glean tests were constructed. Could you please confirm that when using quick tests, glean still gets the --quick appropriately? We should probably make the code more robust agains this, as I believe this happened in the past. E.g, adding a big fat warning before GleanTest.globalParams statement, and/or make GleanTest work in such way that it will pick up posterior changes in GleanTest.globalParams. Jose ----- Original Message ----- > Signed-off-by: Dylan Baker <[email protected]> > --- > tests/quick.py | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/tests/quick.py b/tests/quick.py > index 0f8c7f3..939aded 100644 > --- a/tests/quick.py > +++ b/tests/quick.py > @@ -1,15 +1,11 @@ > # -*- coding: utf-8 -*- > > -import os.path > - > -global profile > from framework.gleantest import GleanTest > +from tests.all import profile > > __all__ = ['profile'] > > -GleanTest.globalParams += [ "--quick" ] > - > -execfile(os.path.dirname(__file__) + '/all.py') > +GleanTest.globalParams += ["--quick"] > > # These take too long > del profile.tests['shaders']['glsl-fs-inline-explosion'] > -- > 1.8.5.2 > > _______________________________________________ > Piglit mailing list > [email protected] > https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/piglit&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=NMr9uy2iTjWVixC0wOcYCWEIYhfo80qKwRgdodpoDzA%3D%0A&m=sEsxINixJ1aun5RPlXnqBxCRoMjmfOtKQwWgx9LUbG0%3D%0A&s=87fcee13d2e88fcd64325d18682168cef30680c9a38de0238d48a06251b7c68a > _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
