On Thursday, February 13, 2014 02:56:16 PM Tom Stellard wrote: > On Thu, Feb 13, 2014 at 10:59:13AM -0800, Dylan Baker wrote: > > In the mentioned commit the signature of Test.interpretResult was > > changed from (self, out, returncode, results, dmesg) to (self, out, > > returncode, results), however, this was not applied to GTest, which > > retained the dmesg argument. > > > > This patch fixes that bug. > > Tested-by: Tom Stellard <[email protected]> > > What would I need to do to add dmesg support to gtest? > > > Signed-off-by: Dylan Baker <[email protected]> > > > > --- > > > > framework/gtest.py | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/framework/gtest.py b/framework/gtest.py > > index 7b474f3..00ed6db 100644 > > --- a/framework/gtest.py > > +++ b/framework/gtest.py > > @@ -29,7 +29,7 @@ import re > > > > from framework.exectest import ExecTest > > > > class GTest(ExecTest): > > - def interpretResult(self, out, returncode, results, dmesg): > > > > + def interpretResult(self, out, returncode, results): > > # Since gtests can have several subtets, if any of the subtests > > fail > > # then we need to report fail. > > if len(re.findall('FAILED', out, re.MULTILINE)) > 0:
Nothing, I put the dmesg handling stuff in ExecTest.execute() which is called to run every test, so every test class should have dmesg support automatically.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
