On 04/09/2014 12:27 AM, Ken Phillis Jr wrote:
The patch looks good, but I would suggest improving commit message...
for example...
Title (line 1): GLSL ES fix default precision qualifiers
The OpenGl ES specification for (whatever the version is being checked
against) section 4.5.4 ("Default precision qualifier") : The fragment
language has no default precision qualifier for floating point types.
Hence for float, floating point vector and matrix variable
declarations, either the declaration must include a precision
qualifier or the default float precision must have been previously
declared.
I'm not sure I understand what this patch fixes. I thought the
"precision mediump float;" declaration that is present in all those
tests is enough.
--
Petri Latvala
_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit
