No idea if this patch is correct or not, but here are a few points of procedure:
(a) Please supply a meaningful subject. The subject should be the top line of the git commit, the body should contain the next lines. "git send-email" will do the right thing, although you can of course do it by hand. (b) Your patch won't apply. It appears to have extra newlines thrown in between every line. I'm guessing this is something that your e-mail client helpfully did. Again, using "get send-email" will prevent such issues. (c) Make sure that the description body is wrapped to 72 characters. (That way it can be displayed within 80 chars if the body is indented with a tab, as 'git show' does, for example.) A good test is to send the email to just yourself, grab the raw email, and run it through "git am". If it applies the patch as expected, your method is good. Otherwise adjust until you get the desired result. Cheers, -ilia On Tue, Apr 15, 2014 at 10:05 PM, Guo, Johney <[email protected]> wrote: > Viewport should be 128x128, or else, piglit_probe_rect_halves_equal_rgba > would get wrong pixel value. > > > > --- > > tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c > b/tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c > > index 59d8748..cc397cb 100644 > > --- a/tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c > > +++ b/tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c > > @@ -289,6 +289,7 @@ piglit_display(void) > > bool pass = true; > > > > glClear(GL_COLOR_BUFFER_BIT); > > + glViewport(0, 0, window_width, window_height); > > for (level = 0; level < num_levels; ++level) { > > glUniform2f(level_pixel_size_loc, > > (float) level_width, > > -- > > 1.8.4.msysgit.0 > > > > > > > _______________________________________________ > Piglit mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/piglit > _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
