Jordan, I think patches 1 and 2 look good. You have my r-b on those.
I have a branch here: https://github.com/dcbaker/piglit piglit-cmd that IMO has a more elegant solution for a piglit executable. The big advantages I see to my approach is that there is very little hand rolled code, we don't need cmake to populate any data for us, and it works in all three use cases (not built, not installed; built, not installed; built, installed). I have tested my piglit in all three applications and it works for me, would you have a look? -Dylan On Wednesday, April 30, 2014 10:28:54 Jordan Justen wrote: > Move piglit binaries and libraries out of the system paths > > Add a piglit wrapper command to easily run piglit commands > in the new install location > > git://people.freedesktop.org/~jljusten/piglit piglit-cmd > > Jordan Justen (3): > cmake: Install under separate piglit directory > cmake: Add version suffix for install paths > piglit: Add piglit command > > CMakeLists.txt | 43 ++++++++++++++++++---- > cmake/piglit_util.cmake | 4 +-- > piglit.in | 42 ++++++++++++++++++++++ > piglit_cmd.py | 96 > +++++++++++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 177 insertions(+), 8 deletions(-) > create mode 100755 piglit.in > create mode 100755 piglit_cmd.py > >
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Piglit mailing list Piglit@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/piglit
