I just posted a patch for the viewport issue in oes_compressed_etc2_texture-miptree.c
My other patches for changing the default window size to 160x160 and related fixes for a few other tests are out for review. -Brian On 05/03/2014 08:34 PM, Guo, Johney wrote: > Except for default window size changes, I think glViewport() should be fixed > firstly. > If applying glViewport() call in display() function, this test will not rely > on default window size. > > > Thanks. > -----Original Message----- > From: Piglit [mailto:[email protected]] On Behalf Of Brian > Paul > Sent: 2014年5月1日 22:02 > To: [email protected] > Subject: Re: [Piglit] [PATCH] > fixed-oes_compressed_etc2_texture-miptree-failure > > I still haven't committed the patch to change the default window size to > 160x160. I want to do a few test runs to make sure there's no regressions. > But on my two attempts with nvidia's driver I've had a system crash and an X > server hang. Ugh. I wonder if anyone at nvidia tests piglit. > > I'm doing an llvmpipe run in the mean time... > > -Brian > > > > On 04/30/2014 01:03 PM, Ian Romanick wrote: >> Is this problem fixed with Brian's recent commits? >> >> On 04/16/2014 08:29 PM, Guo, Johney wrote: >>> - glut config.window_width should be > 160 so as to avoid warning >>> message. >>> - fopen ktx texture file should be binary mode >>> - viewport need be reset in each display, since it has changed in >>> glut reshape() function >>> >>> Signed-off-by: infi <[email protected]> >>> --- >>> tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c | 3 ++- >>> tests/util/piglit_ktx.c | 4 ++-- >>> 2 files changed, 4 insertions(+), 3 deletions(-) >>> >>> diff --git >>> a/tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c >>> b/tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c >>> index 59d8748..eeda3cb 100644 >>> --- a/tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c >>> +++ b/tests/spec/gles-3.0/oes_compressed_etc2_texture-miptree.c >>> @@ -289,6 +289,7 @@ piglit_display(void) >>> bool pass = true; >>> >>> glClear(GL_COLOR_BUFFER_BIT); >>> + glViewport(0, 0, window_width, window_height); >>> for (level = 0; level < num_levels; ++level) { >>> glUniform2f(level_pixel_size_loc, >>> (float) level_width, >>> @@ -339,7 +340,7 @@ PIGLIT_GL_TEST_CONFIG_BEGIN >>> >>> config.supports_gl_es_version = 30; >>> >>> - config.window_width = 150; >>> + config.window_width = 160; >>> config.window_height = 150; >>> config.window_visual = PIGLIT_GL_VISUAL_DOUBLE | PIGLIT_GL_VISUAL_RGBA; >>> PIGLIT_GL_TEST_CONFIG_END >>> diff --git a/tests/util/piglit_ktx.c b/tests/util/piglit_ktx.c index >>> b60f737..d844540 100644 >>> --- a/tests/util/piglit_ktx.c >>> +++ b/tests/util/piglit_ktx.c >>> @@ -436,7 +436,7 @@ piglit_ktx_read_file(const char *filename) >>> if (self == NULL) >>> goto out_of_memory; >>> >>> - file = fopen(filename, "r"); >>> + file = fopen(filename, "rb"); >>> if (file == NULL) >>> goto bad_open; >>> >>> @@ -521,7 +521,7 @@ piglit_ktx_write_file(struct piglit_ktx *self, const >>> char *filename) >>> size_t size_written = 0; >>> bool ok = true; >>> >>> - file = fopen(filename, "w"); >>> + file = fopen(filename, "wb"); >>> if (file == NULL) >>> goto bad_open; >>> >>> >> >> _______________________________________________ >> Piglit mailing list >> [email protected] >> https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.or >> g/mailman/listinfo/piglit&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzz >> TgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m=hi96sKi%2FEw8%2BXQdr >> mnwXcMJJkm7R9VWSM9Y9sTUkGkU%3D%0A&s=5fa4564764e5cee9320c31733b7a579095 >> 57a5ada269edb65a3bc507ad85e9d8 >> > > _______________________________________________ > Piglit mailing list > [email protected] > https://urldefense.proofpoint.com/v1/url?u=http://lists.freedesktop.org/mailman/listinfo/piglit&k=oIvRg1%2BdGAgOoM1BIlLLqw%3D%3D%0A&r=lGQMzzTgII0I7jefp2FHq7WtZ%2BTLs8wadB%2BiIj9xpBY%3D%0A&m=bnN3PsRdAOFHNlvQwCD1lYqY8GJDegIudYUqDcWttNo%3D%0A&s=c57567e611ca44267710f6307c81e5e1011a4ec122a95c4feb1cbb69ee271e1b > _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
