On Tuesday, May 13, 2014 17:19:31 Ilia Mirkin wrote: > On Tue, May 13, 2014 at 4:36 PM, Dylan Baker <[email protected]> wrote: > > On Tuesday, May 13, 2014 15:14:28 Ilia Mirkin wrote: > >> Oh, also, something that occurred to me when looking at the GLSL > >> parser test, but applies just as much here... why are you doing this > >> in the first place? It seems like this breaks the abstraction between > >> "test framework" and "tests" which is otherwise maintained. IMHO the > >> glean/glsl test stuff belongs in tests/. > > > > The status quo has been that tests that are checked into git ("native" > > piglit tests) have their python support code in framework/, external > > integration goes in tests/. > > So you'd be in favour of moving IGTTest out of igt.py and into > exectest.py? I dunno, seems like framework over-reach to me. But like > I said, if others like it, wtvr. > > -ilia
Like I said, I think what we have now is a nice compromise. IMHO tests is the folder for the test profile and the actual GL/CL tests, keeping python out feels natural to me, but I don't feel that strongly about it.
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
