On Mon, Jun 2, 2014 at 7:17 AM, Dylan Baker <[email protected]> wrote: > On Monday, June 02, 2014 12:46:59 PM Marek Olšák wrote: >> From: Marek Olšák <[email protected]> >> >> --- >> framework/summary.py | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/framework/summary.py b/framework/summary.py >> index c905b98..d71fb53 100644 >> --- a/framework/summary.py >> +++ b/framework/summary.py >> @@ -385,6 +385,7 @@ class Summary: >> self.tests['changes'].add(test) >> elif last in [so.SKIP, so.NOTRUN] and first not in >> [so.SKIP, so.NOTRUN]: self.tests['disabled'].add(test) >> + self.tests['changes'].add(test) >> elif first < last: >> self.tests['regressions'].add(test) >> self.tests['changes'].add(test) > > Reviewed-by: Dylan Baker <[email protected]>
While personally I'm all in favour of this change, I seem to recall someone not wanting me to do this because there was a use-case whereby you'd do a full piglit run, then make some modifications, and then run a small subset of the tests (presumably over and over until they worked) and compare them to the full run, looking at the changes page. In that case, you wouldn't want all of the tests that weren't run because they weren't part of the subset to appear on the changes page. -ilia _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
