On Tuesday, June 10, 2014 08:16:04 PM [email protected] wrote: > From: José Fonseca <[email protected]> > > Just like piglit_report_result(PIGLIT_SKIP) does. > > Otherwise these tests are considered failures or -- with my commit > 058e0f8a1e536b68ef43d27ada80645845a39e19 -- crashes. > --- > framework/exectest.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/framework/exectest.py b/framework/exectest.py > index a833066..a5e06ae 100644 > --- a/framework/exectest.py > +++ b/framework/exectest.py > @@ -205,7 +205,7 @@ class Test(object): > out = ("PIGLIT: {'result': 'skip'}\n" > "Test executable not found.\n") > err = "" > - returncode = None > + returncode = 0 > else: > raise e
I'm not excited by this, tests that don't run shouldn't have return codes, especially not the 'everything is fine!' return code. I'd prefer to fix the check that 058e0f8a1e536b68ef43d27ada80645845a39e19 broke by replacing: if self.result['returncode'] < 0 with if self.result['returncode'] is not None and self.result['returncode'] < 0
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
