On Fri, Jul 4, 2014 at 1:09 PM, Marek Olšák <[email protected]> wrote:
> See the master branch at:
> http://cgit.freedesktop.org/~mareko/piglit/
>
> It passes with my latest Mesa and LLVM patches on radeonsi. Also see
> my st/mesa fix for samplerCubeShadow, which you will probably need.
And some further fixes, it would seem =/
BTW:
$ echo texture(bias)
bash: syntax error near unexpected token `('
I know I can stick it in ' ', but these sorts of things make it harder
to copy command lines around from, e.g., piglit run info.
>
> I also forgot to say that it tests all texture targets including the
> shadow targets, so it covers shadow mapping too.
>
> On failure, it usually reports which level was expected and which
> level was observed, or that a wrong layer or offset was observed (it
> doesn't say which one though). It doesn't just report some random
> color that you have to interpret by yourself.
>
> Marek
>
> On Fri, Jul 4, 2014 at 6:10 PM, Ilia Mirkin <[email protected]> wrote:
>> On Fri, Jul 4, 2014 at 10:09 AM, Marek Olšák <[email protected]> wrote:
>>> Hi,
>>>
>>> This adds tests for all GLSL texture function. The tex-miplevel-selection
>>> test is used, since it's a good foundation for testing texturing with
>>> mipmaps.
>>>
>>> All functions are tested except for textureGrad with Cube samplers (I think
>>> the GL spec doesn't define how Cube derivates are interpreted).
>>>
>>> All combinations of the following states: BASE_LEVEL, MAX_LEVEL, MIN_LOD,
>>> MAX_LOD, LOD_BIAS or shader-provided bias, mipmap or no mipmap filtering,
>>> and scaling texture coordinates to affect the implicit LOD, are tested with
>>> almost all GLSL functions. 2DRect is an exception, since it doesn't have
>>> any mipmap tree.
>>>
>>> This doesn't test every aspect of texturing. Generally, the test only
>>> checks if the correct level and layer/slice/face is sampled except for the
>>> *Offset and 2DRect functions, which test if the correct texel is sampled.
>>>
>>> There is some overlap with other piglit tests, as well as within the test
>>> itself, because it tests both GL2 (e.g. texture2DProj) and GL3 (e.g.
>>> textureProj) functions.
>>
>> This is awesome! :) One small thing, it's a little dangerous to expect
>> arguments with *'s. Shells tend to expand them, so if you have random
>> files lying around with the wrong names, it'll make it a lot harder to
>> pass it in (would have to be escaped).
>>
>> Is there a tree with this somewhere? Should probably give it a go on nouveau.
>>
>> -ilia
_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit
