On Tue, Jul 29, 2014 at 9:46 AM, Jon TURNEY <[email protected]> wrote:
> On 22/07/2014 23:54, Anuj Phogat wrote: > >> On Mon, Jul 21, 2014 at 11:21 AM, Jon TURNEY wrote: >> >>> Fix a typo so that GL_PROXY_TEXTURE_RECTANGLE test actually tests that. >>> --- >>> tests/texturing/max-texture-size.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/tests/texturing/max-texture-size.c >>> b/tests/texturing/max-texture-size.c >>> index 8afa9ef..e9f5c6b 100644 >>> --- a/tests/texturing/max-texture-size.c >>> +++ b/tests/texturing/max-texture-size.c >>> @@ -195,8 +195,8 @@ test_proxy_texture_size(GLenum target, GLenum >>> internalformat) >>> break; >>> >>> case GL_TEXTURE_RECTANGLE: >>> - glTexImage2D(target, 0, internalformat, maxSide, >>> - maxSide, 0, GL_RGBA, GL_FLOAT, NULL); >>> + glTexImage2D(GL_PROXY_TEXTURE_RECTANGLE, 0, >>> internalformat, >>> + maxSide, maxSide, 0, GL_RGBA, GL_FLOAT, >>> NULL); >>> break; >>> >> It will be nice to define a proxyTarget variable here and get its value >> using >> getProxyTarget(target). Then you can combine the cases for TEXTURE_2D, >> TEXTURE_RECTANGLE and TEXTURE_CUBE_MAP together. >> Whether you decide to use my suggestion or not, patch is: >> Reviewed-by: Anuj Phogat <anuj.phogat-Re5JQEeQqe8AvxtiuMwx3w@public. >> gmane.org> >> > > Would you mind committing this patch for me? I don't think I have commit > access to piglit. > > Pushed. > > _______________________________________________ > Piglit mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/piglit >
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
