On 09/03/2014 01:51 AM, Ken Phillis Jr wrote: > I agree, but I would suggest further changes. This extension has a lot > of variations... > > Core Variation 1: OpenGL 3.3 - Simplifies things, but is not a good > benchmark. > > Core Variation 2: OpenGL 1.0 with three extensions > ARB_explicit_attrib_location, GL_ARB_vertex_shader, ARB_shader_objects >
I don't see how this would make sense, we are testing specific parts of GL_ARB_explicit_uniform_location implementation here, not anything else. If one wants to test interaction or behavior with other extensions then it requires a specific test for that purpose. I dislike already the fact that I need to require/enable GL_ARB_explicit_attrib_location which is not used at all by these tests. > Side Variation 1: interaction with ARB_shader_subroutine > > Side Variation 2: ARB_explicit_attrib_location has various > interactions with the following extensions... > GL_ARB_blend_func_extended, GL_ARB_separate_shader_objects, > GL_ARB_gpu_shader_fp64, OpenGL 4.0, and OpenGL 4.1. > [1] Specification for ARB_explicit_uniform_location > https://www.opengl.org/registry/specs/ARB/explicit_uniform_location.txt > > [2] > Specification for ARB_explicit_attrib_location > https://www.opengl.org/registry/specs/ARB/explicit_attrib_location.txt > > > On Tue, Sep 2, 2014 at 5:07 PM, Matt Turner <[email protected] > <mailto:[email protected]>> wrote: > > On Tue, Sep 2, 2014 at 1:32 AM, Tapani Pälli > <[email protected] <mailto:[email protected]>> wrote: > > Signed-off-by: Tapani Pälli <[email protected] > <mailto:[email protected]>> > > --- > > tests/spec/arb_explicit_uniform_location/array-elements.c > | 6 ++++-- > > .../spec/arb_explicit_uniform_location/compiler/layout-01.frag > | 7 ++++--- > > .../spec/arb_explicit_uniform_location/compiler/layout-01.vert > | 7 ++++--- > > tests/spec/arb_explicit_uniform_location/inactive-uniform.c > | 6 ++++-- > > .../linker/overlap-array-loc-stages.shader_test > | 10 ++++++---- > > .../linker/overlap-array-loc.shader_test > | 7 ++++--- > > .../linker/overlap-location-across-stages.shader_test > | 10 ++++++---- > > .../linker/set-explicit-location-once-decl-twice.shader_test > | 10 ++++++---- > > .../linker/set-explicit-location-twice.shader_test > | 9 ++++++--- > > .../linker/set-location-to-sampler.shader_test > | 7 ++++--- > > .../linker/set-same-explicit-location-twice.shader_test > | 10 ++++++---- > > .../linker/unused-uniform-reserve-location.shader_test > | 10 ++++++---- > > tests/spec/arb_explicit_uniform_location/loc-boundaries.c > | 6 ++++-- > > .../arb_explicit_uniform_location/preprocessor/define.frag > | 7 ++++--- > > .../arb_explicit_uniform_location/preprocessor/define.vert > | 7 ++++--- > > 15 files changed, 72 insertions(+), 47 deletions(-) > > > > diff --git > a/tests/spec/arb_explicit_uniform_location/array-elements.c > b/tests/spec/arb_explicit_uniform_location/array-elements.c > > index 72cb784..1fa91d4 100644 > > --- a/tests/spec/arb_explicit_uniform_location/array-elements.c > > +++ b/tests/spec/arb_explicit_uniform_location/array-elements.c > > @@ -34,7 +34,7 @@ > > > > PIGLIT_GL_TEST_CONFIG_BEGIN > > > > - config.supports_gl_core_version = 33; > > + config.supports_gl_compat_version = 20; > > config.window_visual = PIGLIT_GL_VISUAL_RGB; > > > > PIGLIT_GL_TEST_CONFIG_END > > @@ -52,7 +52,8 @@ static const char vs_text[] = > > "}"; > > > > static const char fs_text[] = > > - "#version 330\n" > > + "#version 130\n" > > You're asking for only a GL 2.0 version, but a version 130 shader. > Shouldn't you be asking for a GL 3.0 minimum version? > _______________________________________________ > Piglit mailing list > [email protected] <mailto:[email protected]> > http://lists.freedesktop.org/mailman/listinfo/piglit > >
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
