Rather than returning False if is_skip() doesn't generate a True result, it should return super().is_skip(). This fixes potential bugs caused by introducing an is_skip() above PiglitGLTest in the class hierarchy.
Signed-off-by: Dylan Baker <[email protected]> --- framework/test/piglit_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/test/piglit_test.py b/framework/test/piglit_test.py index 9a301c2..cadd3ed 100644 --- a/framework/test/piglit_test.py +++ b/framework/test/piglit_test.py @@ -124,7 +124,7 @@ class PiglitGLTest(WindowResizeMixin, PiglitBaseTest): return True elif self.__exclude_platforms and platform in self.__exclude_platforms: return True - return False + return super(PiglitGLTest, self).is_skip() @PiglitBaseTest.command.getter def command(self): -- 2.1.2 _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
