I've commented on the bug, but just noticed this review now after commenting.
> Does piglit have a place where wrapper functions like this should live? I think that would be tests/util/piglit-util.h But I suspect this change might break MSVC 2013 (which probably defines or declares the function)... Like I said to Vinson, unless there is a major reason, I'd rather bump the minimum MSVC version required to build piglit to MSVC 2013, instead of having to deal older MSVC 2012 versions. BTW, does anybody else on the maling list care for MSVC versions older than 2013? As they say, "speak now or forever hold your peace.. " Jose ________________________________________ From: Piglit <[email protected]> on behalf of Ian Romanick <[email protected]> Sent: 29 October 2014 21:34 To: [email protected] Cc: Ian Romanick Subject: [Piglit] [PATCH] shader_runner: Work around MSVC lacking strtoll From: Ian Romanick <[email protected]> Does piglit have a place where wrapper functions like this should live? Signed-off-by: Ian Romanick <[email protected]> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=85528 Cc: [email protected] --- tests/shaders/shader_runner.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/shaders/shader_runner.c b/tests/shaders/shader_runner.c index 1f93216..465d042 100644 --- a/tests/shaders/shader_runner.c +++ b/tests/shaders/shader_runner.c @@ -31,6 +31,10 @@ #include <libgen.h> #endif +#if defined(_MSC_VER) +#define strtoll _strtoi64 +#endif + #include "piglit-util-gl.h" #include "piglit-vbo.h" -- 1.8.1.4 _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
