Ben, Emil,

Thanks for confirming this. (It's quite hard to keep in mind what's supported or on on MSVC!)

Patch sounds great as is then.

Jose

On 18/11/14 19:04, Ben Widawsky wrote:
On Tue, Nov 18, 2014 at 06:25:59PM +0000, Jose Fonseca wrote:
You're sure? I thought that MSVC 2013 only had _library_ support for C99, but I 
confess I haven't tested..


Jose

Oops. Didn't see this since my mail wasn't actually in a to, or cc. I responded
to Brian's mail with the best I could find:
https://urldefense.proofpoint.com/v2/url?u=http-3A__blogs.msdn.com_b_vcblog_archive_2013_06_28_c-2D11-2D14-2Dstl-2Dfeatures-2Dfixes-2Dand-2Dbreaking-2Dchanges-2Din-2Dvs-2D2013.aspx&d=AAIBAg&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=qTGaRHpVUc8nTQuP4GPX_CZcEKUlhfZEVdKJKUlk_Uo&s=OGsVe-1lb_vJtjwCbZVgAckNNylUkPDSQkYh_0FWv5s&e=

(See the bit toward the bottom of the first page with the C99 features)


________________________________________
From: Piglit <[email protected]> on behalf of Emil Velikov 
<[email protected]>
Sent: 18 November 2014 17:17
To: Brian Paul; [email protected]
Cc: [email protected]
Subject: Re: [Piglit] [PATCH 5/6] ARB_pipeline_statistics_query (geom): basic 
test

On 18/11/14 15:14, Brian Paul wrote:
On 11/17/2014 05:00 PM, Ben Widawsky wrote:
Signed-off-by: Ben Widawsky <[email protected]>
[snip]
+static struct query queries[] = {
+    {
+     .query = GL_GEOMETRY_SHADER_INVOCATIONS,
+     .name = "GL_GEOMETRY_SHADER_INVOCATIONS",
+     .expected = NUM_PRIMS},
+    {
+     .query = GL_GEOMETRY_SHADER_PRIMITIVES_EMITTED_ARB,
+     .name = "GL_GEOMETRY_SHADER_PRIMITIVES_EMITTED_ARB",
+     .expected = NUM_PRIMS}

Unless MSVC 2013 added support for named initializers, this won't
compile there.

MSVC 2013 has support for named initialisers. We should be safe here.

-Emil

_______________________________________________
Piglit mailing list
[email protected]
https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_mailman_listinfo_piglit&d=AAIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=NCgOo9oLZHwfeq4zQW6_WaeMk9HJ_C_DIa4ALZKrbtc&s=Uez3tmRkauv0Nn3BVSeoh_W7ZaoMa2s5IeeKun_CP0w&e=
_______________________________________________
Piglit mailing list
[email protected]
https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_mailman_listinfo_piglit&d=AAIBAg&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=zfmBZnnVGHeYde45pMKNnVyzeaZbdIqVLprmZCM2zzE&m=qTGaRHpVUc8nTQuP4GPX_CZcEKUlhfZEVdKJKUlk_Uo&s=BiQnYUWLmiKhAh4Rjp0cZQUCY3SsyLsTYJYM-nmukjc&e=


_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to