On 04/02/15 11:10, Francisco Jerez wrote:
Brian Paul <[email protected]> writes:
On 02/03/2015 01:08 PM, Francisco Jerez wrote:
Francisco Jerez <[email protected]> writes:
Francisco Jerez <[email protected]> writes:
Brian Paul <[email protected]> writes:
MSVC doesn't seem to like function calls inside struct initializers.
That's awful. But fine:
Reviewed-by: Francisco Jerez <[email protected]>
Actually it's surprising that you got it to build with so few changes.
I'd expect you to find *many* more function calls inside struct
initializers. Does it actually work with this change or did you forget
to include some files?
Brian, if that's the case don't bother to fix all the function calls in
struct initalizers, just let me know, I'd like to try a less intrusive
solution.
I'm just fixing the errors found via our automated build (which didn't
complete). I don't have a MSVC piglit build on my local system ATM.
-Brian
Hi Brian, if you still have trouble to get this to build with MSVC, can
you give the attached patch a try?
Francisco,
I realized there has been as recent upgrade of MSVC 2013 -- Update 4 --,
so I upgraded MSVC 2013 on my development machine and the problem went
away. It appears that neither Brian's or your patch is necessary with
2013 U4.
(I'm still waiting for a full build to complete to verify)
Sorry not checking this sooner... I was under the impression that
Windows Update would upgrade Visual Studio automatically but that's not
the case. I started the upgrade manually yesterday, but it took
forever, so only this morning I was able to verify whether there was any
improvement.
We already require 2013, and U4 is a free upgrade, so there's no reason
not to bump MSVC requirements to 2013U4. So I recommend we devise a
cmake check for MSVC2013U4 (I'll do it) and back out Brian's change.
Jose
_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit
