On Wed, Feb 25, 2015 at 2:18 AM, Tapani Pälli <[email protected]> wrote: > > > On 02/19/2015 08:33 PM, Ilia Mirkin wrote: >> >> On Thu, Feb 19, 2015 at 7:54 AM, Tapani Pälli <[email protected]> >> wrote: >>> >>> +static const char gs_subroutine_text[] = >>> + "#version 150\n" >>> + "#extension GL_ARB_explicit_attrib_location : require\n" >>> + "#extension GL_ARB_explicit_uniform_location : require\n" >>> + "#extension GL_ARB_shader_subroutine : require\n" >>> + "#extension GL_EXT_geometry_shader4 : require\n" >> >> >> oops? You're requiring GLSL 1.50, no need for EXT_geometry_shader4, right? >> > > True, I'll chop it away, does it otherwise look fine?
I think there was another instance of you checking for ARB_geometry_shader4. As for the rest of it, I haven't read the spec in enough detail to really tell. You'll need someone more familiar with this than myself to go over it. (Or just push unreviewed as a lot of piglit tends to be due to lack of reviewers.) -ilia _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
