While developing virgl I found this combo wasn't tested by any of the current tests, emit, skip, next buffer, emit.
Just add a test to this to exercise the codepath. Signed-off-by: Dave Airlie <[email protected]> --- tests/all.py | 2 +- tests/spec/ext_transform_feedback/output-type.c | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/tests/all.py b/tests/all.py index 805361c..4631510 100644 --- a/tests/all.py +++ b/tests/all.py @@ -3389,7 +3389,7 @@ with profile.group_manager( 'gl_SkipComponents2', 'gl_SkipComponents3', 'gl_SkipComponents4', 'gl_NextBuffer-gl_SkipComponents1-gl_NextBuffer', - 'gl_NextBuffer-gl_NextBuffer', 'gl_SkipComponents1234']: + 'gl_NextBuffer-gl_NextBuffer', 'gl_SkipComponents1234', 'gl_SkipComponents1-gl_NextBuffer']: g(['ext_transform_feedback-output-type', param], param) with profile.group_manager( diff --git a/tests/spec/ext_transform_feedback/output-type.c b/tests/spec/ext_transform_feedback/output-type.c index d76c67d..5b6c625 100644 --- a/tests/spec/ext_transform_feedback/output-type.c +++ b/tests/spec/ext_transform_feedback/output-type.c @@ -1376,6 +1376,24 @@ struct test_desc { true /* is transform_feedback3 */ }, { + "gl_SkipComponents1-gl_NextBuffer", /* name */ + + "#version 120\n" /* vs */ + "varying float r[2];" + "void main() {" + " gl_Position = ftransform();" + " r = float[2](0.4, 0.5);" + "}", + + 4, /* num_varyings, varyings */ + {"r[0]", "gl_SkipComponents1", "gl_NextBuffer", "r[1]"}, + + true, /* is_floating_point */ + {2, 1}, /* num_elements, expected_float, expected_int */ + {{0.4, DEFAULT_VALUE}, {0.5}}, {{0}}, + true /* is transform_feedback3 */ + }, + { "gl_NextBuffer-gl_SkipComponents1-gl_NextBuffer", /* name */ "#version 120\n" /* vs */ -- 2.1.0 _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
