On Mon, Apr 6, 2015 at 6:00 PM, Micah Fedke <[email protected]> wrote: > Ilia, > > All comments thus far addressed here: > http://cgit.collabora.com/git/user/fedke.m/piglit.git/log/?h=complex_tolerances_straight_comments1
If you make those _foo_tol functions take the right args, no need for the lambdas. Doesn't seem like rettype is used by any of the functions. Also for the constants, you can just do lambda *args: 2.5 Also why not define arg_float_check as all(...) in the first place rather than computing the array, and then running all on it. > Yeah, Mako is really hard to read. I couldn't find much for Mako style > guides online, but I tried to keep a common indent scheme for all Mako (%) > lines. Lines of content, however, have to be indented according to how they > will appear after rendering the template, which makes the template look very > messy. I'm just going to trust you that you didn't totally break everything :) Reading over those diffs is beyond my caring level right now. Getting close :) -ilia _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
