Verified the constants from GLSL ES 3.1 spec, one copy-paste error:

gl_MaxAtomicCounterBufferSize should be 32

With this fixed the whole series is
Reviewed-by: Tapani Pälli <[email protected]>

On 04/30/2015 02:01 AM, Ian Romanick wrote:
From: Ian Romanick <[email protected]>

minimum-maximums.txt was created by copy-and-pasting directly from
section 7.2 followed by some by-hand cleanups.  This is why the names
are not listed in alphabetic order (or in the same order as the
glsl-es-3.00 test).

(In the OpenGL ES 3.10 spec, the built-in constants are in section 7.2
instead of section 7.3.)

Signed-off-by: Ian Romanick <[email protected]>
---
  tests/all.py                                 |  7 ++++++
  tests/spec/glsl-es-3.10/minimum-maximums.txt | 37 ++++++++++++++++++++++++++++
  2 files changed, 44 insertions(+)
  create mode 100644 tests/spec/glsl-es-3.10/minimum-maximums.txt

diff --git a/tests/all.py b/tests/all.py
index 5138f73..18aa0fc 100755
--- a/tests/all.py
+++ b/tests/all.py
@@ -1650,6 +1650,13 @@ with profile.group_manager(
          grouptools.join('spec', 'glsl-es-3.00', 'execution')) as g:
      g(['varying-struct-centroid_gles3'])

+with profile.group_manager(
+        PiglitGLTest, grouptools.join('spec', 'glsl-es-3.10')) as g:
+    g(['built-in-constants_gles3',
+       os.path.join(TESTS_DIR, 'spec', 'glsl-es-3.10',
+                    'minimum-maximums.txt')],
+      'built-in constants')
+
  # AMD_performance_monitor
  with profile.group_manager(
          PiglitGLTest, grouptools.join('spec', 'AMD_performance_monitor')) as 
g:
diff --git a/tests/spec/glsl-es-3.10/minimum-maximums.txt 
b/tests/spec/glsl-es-3.10/minimum-maximums.txt
new file mode 100644
index 0000000..5f6c6f4
--- /dev/null
+++ b/tests/spec/glsl-es-3.10/minimum-maximums.txt
@@ -0,0 +1,37 @@
+310 es
+gl_MaxVertexAttribs 16
+gl_MaxVertexUniformVectors 256
+gl_MaxVertexOutputVectors 16
+gl_MaxFragmentInputVectors 15
+gl_MaxFragmentUniformVectors 224
+gl_MaxDrawBuffers 4
+gl_MaxVertexTextureImageUnits 16
+gl_MaxCombinedTextureImageUnits 48
+gl_MaxTextureImageUnits 16
+gl_MinProgramTexelOffset -8
+gl_MaxProgramTexelOffset 7
+gl_MaxImageUnits 4
+gl_MaxVertexImageUniforms 0
+gl_MaxFragmentImageUniforms 0
+gl_MaxComputeImageUniforms 4
+gl_MaxCombinedImageUniforms 4
+gl_MaxCombinedShaderOutputResources 4
+gl_MaxComputeWorkGroupCount.x 65535
+gl_MaxComputeWorkGroupCount.y 65535
+gl_MaxComputeWorkGroupCount.z 65535
+gl_MaxComputeWorkGroupSize.x 128
+gl_MaxComputeWorkGroupSize.y 128
+gl_MaxComputeWorkGroupSize.z 64
+gl_MaxComputeUniformComponents 512
+gl_MaxComputeTextureImageUnits 16
+gl_MaxComputeAtomicCounters 8
+gl_MaxComputeAtomicCounterBuffers 1
+gl_MaxVertexAtomicCounters 0
+gl_MaxFragmentAtomicCounters 0
+gl_MaxCombinedAtomicCounters 8
+gl_MaxAtomicCounterBindings 1
+gl_MaxVertexAtomicCounterBuffers 0
+gl_MaxFragmentAtomicCounterBuffers 0
+gl_MaxVertexAtomicCounterBuffers 0
+gl_MaxCombinedAtomicCounterBuffers 1
+gl_MaxAtomicCounterBufferSize 3

_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit

Reply via email to