No problem.
Happy Python 3!
Reviewed-by: Liam Middlebrook <[email protected]>
On 07/06/2015 04:25 PM, Dylan Baker wrote:
* PGP Signed by an unknown key
On Mon, Jul 06, 2015 at 04:18:48PM -0700, Liam Middlebrook wrote:
I find it's generally a good idea to follow the PEP8 standard for Python
formatting.
https://www.python.org/dev/peps/pep-0008/
Absolutely, and except when following PEP8 would produce odd results we
do follow PEP8, and both forms below are valid when less than 80
characters wide, although with the change from render to render_unicode
the change is required to meet the less 80 character suggestion.
Also this change lgtm.
I think it's in the README (or maybe just the mesa README?), but we like
to see an explicit reviewed-by/tested-by/acked-by tag, so that the
author is sure what to put on the patch before pushing. Thanks.
* Unknown Key
* 0x140688EF
_______________________________________________
Piglit mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/piglit