On Fri, Jul 10, 2015 at 10:36:09AM +0100, Emil Velikov wrote: > On 10 July 2015 at 09:22, Dylan Baker <[email protected]> wrote: > > Maybe a better plan is to have the test detect that those aren't defined and > > skip? > >
Please explain why a test checking for required functionality and skipping if that functionality isn't present is not a valid solution? This is AFAICT the way the piglit generally works, a test asks GL if the feature it tests are present, and skips if they are not. So in that case something as simple as: #ifndef <MY_CONSTANT> return PIGLIT_SKIP; #endif at the top of the main function should be sufficient. > A few other suggestions: > - Check that the headers are new enough and bail out early in cmake. > Unfortunately distros may insist on keeping old headers, despite that > updating (and using) them won't cause ABI breakage. This would make it impossible to build new piglit against a sufficiently old version of mesa (or any GL driver) (which could mean a year, or an hour), which would make bisecting regressions impossible. > - Have a local copy of the headers in-tree. > Could get ugly, but many projects seems to be doing it. This also seems less than desirable, because now we're maintaining two copies, which will be error prone. > I'm leaning towards the former, although feel free to use whichever you fancy. > > -Emil Dylan
signature.asc
Description: Digital signature
_______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
