Ian, what happened to this series? I saw that you pushed a small dsa cleanup series, but it doesn't seem like you did the conversion.
I think this has been just sitting there long enough that you can safely just push... I'd much rather have potentially-less-than-perfect tests than having a giant portion of the extension *completely uncovered* by piglit. I'm sure that some of the recent rework has already regressed it, but we won't know until these tests become operational. [Urgh... if only people listened to my annoying complaints instead of dismissing them. Oh well.] Someone on IRC ran into an issue and I wanted to add a test, but I have nothing to copy from. (And I don't actually know GL enough to be able to write from scratch.) On Mon, May 18, 2015 at 4:49 PM, Ian Romanick <[email protected]> wrote: > This series ports almost all of the DSA tests to core profile. There > are three tests that were not ported: > > - gettextureimage-simple was just removed. It is a subset of the other > gettextureimage tests that was designed to reproduce a bug in a driver > that doesn't do core profile. The existing, non-DSA test should be > sufficient, so there's no need for a DSA version. > > - gettextureimage-luminance tests image formats that do not exist in > core profile. > > - gettextureimage-formats makes heavy use of glDrawPixels. See the > patch 25 for more details. Once that is sorted, porting the test > should be easy. > > _______________________________________________ > Piglit mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/piglit _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
