On Tue, Sep 1, 2015 at 12:22 PM, Fredrik Höglund <[email protected]> wrote: > On Tuesday 01 September 2015, Brian Paul wrote: >> On 08/31/2015 05:38 PM, Ilia Mirkin wrote: >> > On Mon, Aug 31, 2015 at 7:29 PM, Ilia Mirkin <[email protected]> wrote: >> >> Reviewed-by: Ilia Mirkin <[email protected]> >> >> >> >> Thanks a lot for doing this! I assume that it fails with your gallium >> >> ARB_copy_image implementation as I predicted? >> >> Yes. In Mesa, I added some code that checks for swizzles and uses >> pipe_context::blit() instead. Seems to fix things, but I need to spend >> more time on it. > > This test is not sufficient though, because it's when you have a copy > from B8G8R8A8 to R16G16, or a similar situation, that things get really > interesting.
Yeah, so the thing is that you can't do this with unsized internal formats, since they're not part of the view classes, but you could (carefully) arrange for a *sized* internal format, like GL_RGBA8 to come out as a BGRA pipe format, and then try to copy it to RG16. And enjoy the fireworks :) But the test is a great start, still has my r-b. -ilia _______________________________________________ Piglit mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/piglit
